[Solved] Can't assign a Tag to VM

manel · October 28, 2015, 11:08am

Hello,

This is the call:

Tagging.create(tag_id,vm.id)`

And this the result:

NoMethodError: undefined method `stringify_keys' for 1000000000181:Fixnum

Thanks!

Here the code:

vm_name = "dfghjkoiuyt56789-1"
vm = VmOrTemplate.find_by_name(vm_name)

cloud_id = vm.ems_id
tenant_id = vm.cloud_tenant_id

cloud = EmsOpenstack.find_by_id(cloud_id)

tenant_name = cloud.cloud_tenants.find_by_id(tenant_id).name

correct_tag = (cloud.name + '_' + tenant_name).downcase

if Tag.find_by_classification_name('tenant/'+correct_tag).nil?
  puts "Tag doesn't exist, ignoring."
else
  tag_defined = 1
  vm.tags.each do |tag|
    if tag.name == '/managed/tenant/' + correct_tag
      tag_defined = 0
      return
    end
  end
  if tag_defined == 1
    tag_id = Tag.find_by_classification_name('/tenant/' + correct_tag)['id']
    Tagging.create(tag_id,vm.id)
  end
end

Fryguy · September 3, 2015, 1:52pm

I don’t think this is the “right” way to tag something. Basically, you should never need to use the Tagging model directly (think private model). The “right” way is to use the tag_add or tag_remove methods on the vm.

cc @gmccullough @gtanzillo Can you verify?

gtanzillo · September 3, 2015, 2:13pm

@Fryguy, that’s correct. Those are the methods that should be used for adding and removing tags for an object.

manel · September 3, 2015, 3:23pm

Definitely it looks much better.
I can’t find the input parameters of tag_add and tag_remove. Where I can find that info @gtanzillo?

Thanks!

jcarter · September 3, 2015, 8:17pm

http://manageiq.org/pdf/ManageIQ-0-Methods_Available_for_Automation-en-US.pdf

Page 36

gmccullough · September 4, 2015, 4:18pm

The tag methods are defined here:

github.com

ManageIQ/manageiq/blob/master/lib/extensions/ar_taggable.rb#L116




  # Apply new tags
  Tag.transaction do
    Tag.parse(list).each do |name|
      next if self.is_tagged_with?(name, options)
      name = File.join(ns, name)
      tag = Tag.where(:name => name).first_or_create
      tag.taggings.create(:taggable => self)
    end
  end
end


def tag_remove(list, options = {})
  ns = Tag.get_namespace(options)


  # Remove tags
  Tag.transaction do
    Tag.parse(list).each do |name|
      name = File.join(ns, name)
      tag = Tag.find_by(:name => name)
      next if tag.nil?

github.com

ManageIQ/manageiq/blob/master/lib/extensions/ar_taggable.rb#L130




  # Remove tags
  Tag.transaction do
    Tag.parse(list).each do |name|
      name = File.join(ns, name)
      tag = Tag.find_by(:name => name)
      next if tag.nil?
      tag.taggings.where(:taggable => self).destroy_all
    end
  end
end


def tagged_with(options = {})
  tagging = Tagging.arel_table
  query = Tag.includes(:taggings).references(:taggings)
  query = query.where(tagging[:taggable_type].eq(self.class.base_class.name))
  query = query.where(tagging[:taggable_id].eq(id))
  ns    = Tag.get_namespace(options)
  query = query.where(Tag.arel_table[:name].matches("#{ns}%")) if ns
  query
end

manel · September 7, 2015, 12:23pm

Thanks to all.
I’m creating and removing tags now:

vm.tag_add(’/managed/tenant/’+correct_tag, {:ns => nil})
vm.tag_remove(tag.name, {:ns => nil})

lkerner · September 9, 2015, 5:25pm

Is there any way to delete the tags from the VMDB? The customer has many extraneous tags that at one time were tagged on an object, but that object has since been deleted. However, the tags are still in the VMDB. I can’t seem to find the method to do this. Thanks.

gmccullough · September 9, 2015, 10:16pm

To completely delete the tags from VMDB use the Classification model:

# Delete single tag
tag = Classification.find_by_name("test_category/test_tag")
tag.destroy

# Delete entire tag category
category = Classification.find_by_name("test_category")
category.destroy

lkerner · September 13, 2015, 6:49pm

What is the difference between tag_add vs tag_assign and tag_remove vs tag_unassign?

In page 18 of this doc:
http://manageiq.org/pdf/ManageIQ-0-Methods_Available_for_Automation-en-US.pdf
and Chapter 2.3 of this doc:
https://access.redhat.com/documentation/en-US/Red_Hat_CloudForms/3.1/html/Management_Engine_5.3_Methods_Available_for_Automation/Base_Methods.html

it references tag_assign , add_tag ,tag_unassign, and clear_tag only. In automate (CFME version 5.4.1.0.20150717083323_6ed7e1c ), vm.tag_add and vm.tag_remove results in the following errors :

NoMethodError: undefined method `tag_add' for #<MiqAeMethodService::MiqAeServiceVmRedhat:0x000000091c1a70>

and

NoMethodError: undefined method `tag_remove' for #<MiqAeMethodService::MiqAeServiceVmRedhat:0x000000015a4bb8>

Both the tag_assign and tag_unassign methods defined in
miq_ae_service_model_base.rb does work in adding/removing tags to
an MiqAeService* object.

gmccullough · September 16, 2015, 3:54pm

The methods discussed in this thread are being called from a Rails runner script which is directly accessing the active_record models. These methods are not directly exposed to automate.

When writing automate methods you want to utilize the tag methods defined in the guides you referenced.